Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] Add temporary expvar extension #5986

Merged
merged 2 commits into from
Sep 15, 2024
Merged

[v2] Add temporary expvar extension #5986

merged 2 commits into from
Sep 15, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Some internal components expose their state via expvar, but OTEL collector does not expose expvar handler

Description of the changes

How was this change tested?

$ go run ./cmd/jaeger
$ curl http://localhost:27777/
{
"badger_compaction_current_num_lsm": 0,
"badger_get_num_lsm": {},
"badger_get_num_memtable": 0,
"badger_get_num_user": 0,
...

@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Sep 14, 2024
@yurishkuro yurishkuro requested a review from a team as a code owner September 14, 2024 23:57
@dosubot dosubot bot added area/otel storage/badger Issues related to badger storage v2 labels Sep 14, 2024
@yurishkuro yurishkuro mentioned this pull request Sep 14, 2024
Open
@yurishkuro
fix
5762279 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro mentioned this pull request Sep 15, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Sep 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.78%. Comparing base (4640518) to head (5762279).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cmd/jaeger/internal/extension/expvar/extension.go 75.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5986      +/-   ##
==========================================
- Coverage   96.82%   96.78%   -0.04%     
==========================================
  Files         345      348       +3     
  Lines       16523    16559      +36     
==========================================
+ Hits        15998    16027      +29     
- Misses        339      343       +4     
- Partials      186      189       +3
Flag Coverage Δ
badger_v1 8.02% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
cassandra-5.x-v1 16.61% <ø> (ø)
cassandra-5.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.82% <ø> (+0.03%) ⬆️
elasticsearch-7.x-v1 18.88% <ø> (+0.04%) ⬆️
elasticsearch-8.x-v1 19.08% <ø> (+0.04%) ⬆️
elasticsearch-8.x-v2 1.82% <ø> (ø)
grpc_v1 9.52% <ø> (ø)
grpc_v2 7.15% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 18.94% <ø> (+0.06%) ⬆️
opensearch-2.x-v1 18.93% <ø> (+0.03%) ⬆️
opensearch-2.x-v2 1.82% <ø> (+0.01%) ⬆️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.27% <86.11%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 55d330b into jaegertracing:main Sep 15, 2024
48 of 49 checks passed
@yurishkuro yurishkuro deleted the expvar-ext branch September 15, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
area/otel changelog:exprimental Change to an experimental part of the code storage/badger Issues related to badger storage v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yurishkuro